# Copyright 2007 Google, Inc. All Rights Reserved. # Licensed to PSF under a Contributor Agreement. """Fixer for dict methods. d.keys() -> list(d.keys()) d.items() -> list(d.items()) d.values() -> list(d.values()) d.iterkeys() -> iter(d.keys()) d.iteritems() -> iter(d.items()) d.itervalues() -> iter(d.values()) d.viewkeys() -> d.keys() d.viewitems() -> d.items() d.viewvalues() -> d.values() Except in certain very specific contexts: the iter() can be dropped when the context is list(), sorted(), iter() or for...in; the list() can be dropped when the context is list() or sorted() (but not iter() or for...in!). Special contexts that apply to both: list(), sorted(), tuple() set(), any(), all(), sum(). Note: iter(d.keys()) could be written as iter(d) but since the original d.iterkeys() was also redundant we don't fix this. And there are (rare) contexts where it makes a difference (e.g. when passing it as an argument to a function that introspects the argument). """ # Local imports from .. import pytree from .. import patcomp from .. import fixer_base from ..fixer_util import Name, Call, Dot from .. import fixer_util iter_exempt = fixer_util.consuming_calls | {"iter"} class FixDict(fixer_base.BaseFix): BM_compatible = True PATTERN = """ power< head=any+ trailer< '.' method=('keys'|'items'|'values'| 'iterkeys'|'iteritems'|'itervalues'| 'viewkeys'|'viewitems'|'viewvalues') > parens=trailer< '(' ')' > tail=any* > """ def transform(self, node, results): head = results["head"] method = results["method"][0] # Extract node for method name tail = results["tail"] syms = self.syms method_name = method.value isiter = method_name.startswith("iter") isview = method_name.startswith("view") if isiter or isview: method_name = method_name[4:] assert method_name in ("keys", "items", "values"), repr(method) head = [n.clone() for n in head] tail = [n.clone() for n in tail] special = not tail and self.in_special_context(node, isiter) args = head + [pytree.Node(syms.trailer, [Dot(), Name(method_name, prefix=method.prefix)]), results["parens"].clone()] new = pytree.Node(syms.power, args) if not (special or isview): new.prefix = "" new = Call(Name("iter" if isiter else "list"), [new]) if tail: new = pytree.Node(syms.power, [new] + tail) new.prefix = node.prefix return new P1 = "power< func=NAME trailer< '(' node=any ')' > any* >" p1 = patcomp.compile_pattern(P1) P2 = """for_stmt< 'for' any 'in' node=any ':' any* > | comp_for< 'for' any 'in' node=any any* > """ p2 = patcomp.compile_pattern(P2) def in_special_context(self, node, isiter): if node.parent is None: return False results = {} if (node.parent.parent is not None and self.p1.match(node.parent.parent, results) and results["node"] is node): if isiter: # iter(d.iterkeys()) -> iter(d.keys()), etc. return results["func"].value in iter_exempt else: # list(d.keys()) -> list(d.keys()), etc. return results["func"].value in fixer_util.consuming_calls if not isiter: return False # for ... in d.iterkeys() -> for ... in d.keys(), etc. return self.p2.match(node.parent, results) and results["node"] is node
Name | Type | Size | Permission | Actions |
---|---|---|---|---|
__pycache__ | Folder | 0755 |
|
|
__init__.py | File | 47 B | 0644 |
|
fix_apply.py | File | 2.29 KB | 0644 |
|
fix_asserts.py | File | 984 B | 0644 |
|
fix_basestring.py | File | 320 B | 0644 |
|
fix_buffer.py | File | 590 B | 0644 |
|
fix_dict.py | File | 3.67 KB | 0644 |
|
fix_except.py | File | 3.27 KB | 0644 |
|
fix_exec.py | File | 979 B | 0644 |
|
fix_execfile.py | File | 2 KB | 0644 |
|
fix_exitfunc.py | File | 2.44 KB | 0644 |
|
fix_filter.py | File | 2.7 KB | 0644 |
|
fix_funcattrs.py | File | 644 B | 0644 |
|
fix_future.py | File | 547 B | 0644 |
|
fix_getcwdu.py | File | 451 B | 0644 |
|
fix_has_key.py | File | 3.12 KB | 0644 |
|
fix_idioms.py | File | 4.76 KB | 0644 |
|
fix_import.py | File | 3.18 KB | 0644 |
|
fix_imports.py | File | 5.55 KB | 0644 |
|
fix_imports2.py | File | 289 B | 0644 |
|
fix_input.py | File | 708 B | 0644 |
|
fix_intern.py | File | 1.12 KB | 0644 |
|
fix_isinstance.py | File | 1.57 KB | 0644 |
|
fix_itertools.py | File | 1.51 KB | 0644 |
|
fix_itertools_imports.py | File | 2.04 KB | 0644 |
|
fix_long.py | File | 476 B | 0644 |
|
fix_map.py | File | 3.55 KB | 0644 |
|
fix_metaclass.py | File | 8 KB | 0644 |
|
fix_methodattrs.py | File | 606 B | 0644 |
|
fix_ne.py | File | 571 B | 0644 |
|
fix_next.py | File | 3.1 KB | 0644 |
|
fix_nonzero.py | File | 591 B | 0644 |
|
fix_numliterals.py | File | 768 B | 0644 |
|
fix_operator.py | File | 3.35 KB | 0644 |
|
fix_paren.py | File | 1.2 KB | 0644 |
|
fix_print.py | File | 2.78 KB | 0644 |
|
fix_raise.py | File | 2.86 KB | 0644 |
|
fix_raw_input.py | File | 454 B | 0644 |
|
fix_reduce.py | File | 837 B | 0644 |
|
fix_reload.py | File | 1.06 KB | 0644 |
|
fix_renames.py | File | 2.17 KB | 0644 |
|
fix_repr.py | File | 613 B | 0644 |
|
fix_set_literal.py | File | 1.66 KB | 0644 |
|
fix_standarderror.py | File | 449 B | 0644 |
|
fix_sys_exc.py | File | 1.01 KB | 0644 |
|
fix_throw.py | File | 1.54 KB | 0644 |
|
fix_tuple_params.py | File | 5.43 KB | 0644 |
|
fix_types.py | File | 1.73 KB | 0644 |
|
fix_unicode.py | File | 1.23 KB | 0644 |
|
fix_urllib.py | File | 8.16 KB | 0644 |
|
fix_ws_comma.py | File | 1.06 KB | 0644 |
|
fix_xrange.py | File | 2.63 KB | 0644 |
|
fix_xreadlines.py | File | 689 B | 0644 |
|
fix_zip.py | File | 1.26 KB | 0644 |
|