"""Fixer for it.next() -> next(it), per PEP 3114.""" # Author: Collin Winter # Things that currently aren't covered: # - listcomp "next" names aren't warned # - "with" statement targets aren't checked # Local imports from ..pgen2 import token from ..pygram import python_symbols as syms from .. import fixer_base from ..fixer_util import Name, Call, find_binding bind_warning = "Calls to builtin next() possibly shadowed by global binding" class FixNext(fixer_base.BaseFix): BM_compatible = True PATTERN = """ power< base=any+ trailer< '.' attr='next' > trailer< '(' ')' > > | power< head=any+ trailer< '.' attr='next' > not trailer< '(' ')' > > | classdef< 'class' any+ ':' suite< any* funcdef< 'def' name='next' parameters< '(' NAME ')' > any+ > any* > > | global=global_stmt< 'global' any* 'next' any* > """ order = "pre" # Pre-order tree traversal def start_tree(self, tree, filename): super(FixNext, self).start_tree(tree, filename) n = find_binding('next', tree) if n: self.warning(n, bind_warning) self.shadowed_next = True else: self.shadowed_next = False def transform(self, node, results): assert results base = results.get("base") attr = results.get("attr") name = results.get("name") if base: if self.shadowed_next: attr.replace(Name("__next__", prefix=attr.prefix)) else: base = [n.clone() for n in base] base[0].prefix = "" node.replace(Call(Name("next", prefix=node.prefix), base)) elif name: n = Name("__next__", prefix=name.prefix) name.replace(n) elif attr: # We don't do this transformation if we're assigning to "x.next". # Unfortunately, it doesn't seem possible to do this in PATTERN, # so it's being done here. if is_assign_target(node): head = results["head"] if "".join([str(n) for n in head]).strip() == '__builtin__': self.warning(node, bind_warning) return attr.replace(Name("__next__")) elif "global" in results: self.warning(node, bind_warning) self.shadowed_next = True ### The following functions help test if node is part of an assignment ### target. def is_assign_target(node): assign = find_assign(node) if assign is None: return False for child in assign.children: if child.type == token.EQUAL: return False elif is_subtree(child, node): return True return False def find_assign(node): if node.type == syms.expr_stmt: return node if node.type == syms.simple_stmt or node.parent is None: return None return find_assign(node.parent) def is_subtree(root, node): if root == node: return True return any(is_subtree(c, node) for c in root.children)
Name | Type | Size | Permission | Actions |
---|---|---|---|---|
__pycache__ | Folder | 0755 |
|
|
__init__.py | File | 47 B | 0644 |
|
fix_apply.py | File | 2.29 KB | 0644 |
|
fix_asserts.py | File | 984 B | 0644 |
|
fix_basestring.py | File | 320 B | 0644 |
|
fix_buffer.py | File | 590 B | 0644 |
|
fix_dict.py | File | 3.67 KB | 0644 |
|
fix_except.py | File | 3.27 KB | 0644 |
|
fix_exec.py | File | 979 B | 0644 |
|
fix_execfile.py | File | 2 KB | 0644 |
|
fix_exitfunc.py | File | 2.44 KB | 0644 |
|
fix_filter.py | File | 2.7 KB | 0644 |
|
fix_funcattrs.py | File | 644 B | 0644 |
|
fix_future.py | File | 547 B | 0644 |
|
fix_getcwdu.py | File | 451 B | 0644 |
|
fix_has_key.py | File | 3.12 KB | 0644 |
|
fix_idioms.py | File | 4.76 KB | 0644 |
|
fix_import.py | File | 3.18 KB | 0644 |
|
fix_imports.py | File | 5.55 KB | 0644 |
|
fix_imports2.py | File | 289 B | 0644 |
|
fix_input.py | File | 708 B | 0644 |
|
fix_intern.py | File | 1.12 KB | 0644 |
|
fix_isinstance.py | File | 1.57 KB | 0644 |
|
fix_itertools.py | File | 1.51 KB | 0644 |
|
fix_itertools_imports.py | File | 2.04 KB | 0644 |
|
fix_long.py | File | 476 B | 0644 |
|
fix_map.py | File | 3.55 KB | 0644 |
|
fix_metaclass.py | File | 8 KB | 0644 |
|
fix_methodattrs.py | File | 606 B | 0644 |
|
fix_ne.py | File | 571 B | 0644 |
|
fix_next.py | File | 3.1 KB | 0644 |
|
fix_nonzero.py | File | 591 B | 0644 |
|
fix_numliterals.py | File | 768 B | 0644 |
|
fix_operator.py | File | 3.35 KB | 0644 |
|
fix_paren.py | File | 1.2 KB | 0644 |
|
fix_print.py | File | 2.78 KB | 0644 |
|
fix_raise.py | File | 2.86 KB | 0644 |
|
fix_raw_input.py | File | 454 B | 0644 |
|
fix_reduce.py | File | 837 B | 0644 |
|
fix_reload.py | File | 1.06 KB | 0644 |
|
fix_renames.py | File | 2.17 KB | 0644 |
|
fix_repr.py | File | 613 B | 0644 |
|
fix_set_literal.py | File | 1.66 KB | 0644 |
|
fix_standarderror.py | File | 449 B | 0644 |
|
fix_sys_exc.py | File | 1.01 KB | 0644 |
|
fix_throw.py | File | 1.54 KB | 0644 |
|
fix_tuple_params.py | File | 5.43 KB | 0644 |
|
fix_types.py | File | 1.73 KB | 0644 |
|
fix_unicode.py | File | 1.23 KB | 0644 |
|
fix_urllib.py | File | 8.16 KB | 0644 |
|
fix_ws_comma.py | File | 1.06 KB | 0644 |
|
fix_xrange.py | File | 2.63 KB | 0644 |
|
fix_xreadlines.py | File | 689 B | 0644 |
|
fix_zip.py | File | 1.26 KB | 0644 |
|